Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supports_conversion_host to Vm #407

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Add supports_conversion_host to Vm #407

merged 1 commit into from
Dec 3, 2018

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented Dec 3, 2018 •
edited
Loading

This sets supports :conversion_host to the Vm model.

The main purpose for this is for the ManageIQ REST API, where support for conversion_host will be checked before attempting to enable or disable the resource.

Part of the V2V effort.

https://bugzilla.redhat.com/show_bug.cgi?id=1622728
https://bugzilla.redhat.com/show_bug.cgi?id=1695810

@miq-bot
Copy link
Member

miq-bot commented Dec 3, 2018

Checked commit https://github.com/djberg96/manageiq-providers-openstack/commit/05c3dea510b2a1ab7cfe5dd001e42dddb556b233 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@mansam mansam merged commit 75c7372 into ManageIQ:master Dec 3, 2018
@aufi aufi added this to the Sprint 100 Ending Dec 3, 2018 milestone Dec 4, 2018
@djberg96 djberg96 mentioned this pull request Feb 6, 2019
Merged
@djberg96
Copy link
Contributor Author

@miq-bot add_label hammer/yes

simaishi pushed a commit that referenced this pull request Mar 29, 2019
@mansam @simaishi
Merge pull request #407 from djberg96/supports_conversion_host
1de7b35 
Add supports_conversion_host to Vm

(cherry picked from commit 75c7372)

https://bugzilla.redhat.com/show_bug.cgi?id=1694229
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 1de7b35994a4b5da7a923a91983688a7504e9de8
Author: Samuel Lucidi <mansam@csh.rit.edu>
Date:   Mon Dec 3 12:39:46 2018 -0500

    Merge pull request #407 from djberg96/supports_conversion_host
    
    Add supports_conversion_host to Vm
    
    (cherry picked from commit 75c73724e034c062566ac789323bcf7c1d691ec5)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1694229

simaishi added a commit that referenced this pull request Apr 1, 2019
@simaishi
Revert "Merge pull request #407 from djberg96/supports_conversion_host"
989a782 
This reverts commit 1de7b35.
@simaishi
Copy link
Contributor

simaishi commented Apr 1, 2019

Reverted the backport:

commit 989a782bcfde3befd4d13cab19a3d956bf8cf4df
Author: Satoe Imaishi <simaishi@redhat.com>
Date:   Mon Apr 1 11:26:19 2019 -0400

    Revert "Merge pull request #407 from djberg96/supports_conversion_host"
    
    This reverts commit 1de7b35994a4b5da7a923a91983688a7504e9de8.

@mturley mturley mentioned this pull request Apr 5, 2019
Merged
simaishi pushed a commit that referenced this pull request Apr 22, 2019
@mansam @simaishi
Merge pull request #407 from djberg96/supports_conversion_host
89747aa 
Add supports_conversion_host to Vm

(cherry picked from commit 75c7372)

https://bugzilla.redhat.com/show_bug.cgi?id=1702019
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 89747aa4890f7efd505a8f65f12e71c4ba47d741
Author: Samuel Lucidi <mansam@csh.rit.edu>
Date:   Mon Dec 3 12:39:46 2018 -0500

    Merge pull request #407 from djberg96/supports_conversion_host
    
    Add supports_conversion_host to Vm
    
    (cherry picked from commit 75c73724e034c062566ac789323bcf7c1d691ec5)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1702019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@djberg96 @miq-bot @simaishi @aufi @mansam